Merged
Conversation
Add new AuthorizationResponse.Type.CANCELLED to differentiate user-initiated cancellations (browser closed, back button pressed) from technical errors (malformed responses, missing data). Previously, both scenarios returned Type.EMPTY with RESULT_OK, making it impossible for client apps to distinguish between them. Now: - Type.CANCELLED → RESULT_CANCELED (user explicitly cancelled) - Type.EMPTY → RESULT_OK (technical error, malformed response) - Type.ERROR → RESULT_OK (OAuth error like access_denied) This allows client applications to handle user cancellations differently from technical failures. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pimpimmi
approved these changes
Feb 23, 2026
auth-lib/src/testAuth/java/com/spotify/sdk/android/auth/LoginActivityAuthTest.java
Outdated
Show resolved
Hide resolved
pimpimmi
approved these changes
Feb 23, 2026
cedrich3
approved these changes
Feb 23, 2026
antonholmberg
force-pushed
the
explicit-cancelations
branch
from
a133d21 to
22f37d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish user cancellations from technical errors with Type.CANCELLED
Add new AuthorizationResponse.Type.CANCELLED to differentiate user-initiated
cancellations (browser closed, back button pressed) from technical errors
(malformed responses, missing data).
Previously, both scenarios returned Type.EMPTY with RESULT_OK, making it
impossible for client apps to distinguish between them. Now: